SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.9.3

Threshold is

Effort is default

Summary

Classes Bugs Errors Missing Classes
47 44 0 0

Files

Class Bugs
net.sf.jguiraffe.examples.tutorial.bgtask.BgTaskCommand 3
net.sf.jguiraffe.examples.tutorial.createfile.AppendTextActionTask 1
net.sf.jguiraffe.examples.tutorial.createfile.ClearTextActionTask 1
net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand 5
net.sf.jguiraffe.examples.tutorial.mainwnd.AbstractDesktopTask 2
net.sf.jguiraffe.examples.tutorial.mainwnd.DummyActionTask 1
net.sf.jguiraffe.examples.tutorial.mainwnd.FileSystemChangeListener 1
net.sf.jguiraffe.examples.tutorial.mainwnd.MainWndController 8
net.sf.jguiraffe.examples.tutorial.mainwnd.RefreshActionTask 1
net.sf.jguiraffe.examples.tutorial.mainwnd.SelectAndOpenFileTask 1
net.sf.jguiraffe.examples.tutorial.mainwnd.TableChangeListener 1
net.sf.jguiraffe.examples.tutorial.mainwnd.TreeChangeListener 1
net.sf.jguiraffe.examples.tutorial.model.DirectoryData 2
net.sf.jguiraffe.examples.tutorial.viewset.CreateViewSettingsCommand 4
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings 6
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDataComparator 1
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDateComparator 1
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDirComparator 1
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileNameComparator 1
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileSizeComparator 1
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettingsFormController 1

net.sf.jguiraffe.examples.tutorial.bgtask.BgTaskCommand

Bug Category Details Line Priority
new net.sf.jguiraffe.examples.tutorial.bgtask.BgTaskCommand(GUISynchronizer, Window, BgTaskData, ProgressBarHandler) may expose internal representation by storing an externally mutable object into BgTaskCommand.data MALICIOUS_CODE EI_EXPOSE_REP2 78 Medium
new net.sf.jguiraffe.examples.tutorial.bgtask.BgTaskCommand(GUISynchronizer, Window, BgTaskData, ProgressBarHandler) may expose internal representation by storing an externally mutable object into BgTaskCommand.infoDialog MALICIOUS_CODE EI_EXPOSE_REP2 77 Medium
new net.sf.jguiraffe.examples.tutorial.bgtask.BgTaskCommand(GUISynchronizer, Window, BgTaskData, ProgressBarHandler) may expose internal representation by storing an externally mutable object into BgTaskCommand.progressHandler MALICIOUS_CODE EI_EXPOSE_REP2 79 Medium

net.sf.jguiraffe.examples.tutorial.createfile.AppendTextActionTask

Bug Category Details Line Priority
new net.sf.jguiraffe.examples.tutorial.createfile.AppendTextActionTask(ComponentHandler, String) may expose internal representation by storing an externally mutable object into AppendTextActionTask.textHandler MALICIOUS_CODE EI_EXPOSE_REP2 49 Medium

net.sf.jguiraffe.examples.tutorial.createfile.ClearTextActionTask

Bug Category Details Line Priority
new net.sf.jguiraffe.examples.tutorial.createfile.ClearTextActionTask(ComponentHandler) may expose internal representation by storing an externally mutable object into ClearTextActionTask.textHandler MALICIOUS_CODE EI_EXPOSE_REP2 44 Medium

net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand

Bug Category Details Line Priority
Exception thrown in class net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand at new net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand(ApplicationContext, CreateFileData, FormAction) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks. BAD_PRACTICE CT_CONSTRUCTOR_THROW 76 Medium
Found reliance on default encoding in net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand.execute(): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 92 High
new net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand(ApplicationContext, CreateFileData, FormAction) may expose internal representation by storing an externally mutable object into CreateFileCommand.appContext MALICIOUS_CODE EI_EXPOSE_REP2 74 Medium
new net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand(ApplicationContext, CreateFileData, FormAction) may expose internal representation by storing an externally mutable object into CreateFileCommand.fileData MALICIOUS_CODE EI_EXPOSE_REP2 78 Medium
new net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand(ApplicationContext, CreateFileData, FormAction) may expose internal representation by storing an externally mutable object into CreateFileCommand.refreshAction MALICIOUS_CODE EI_EXPOSE_REP2 79 Medium

net.sf.jguiraffe.examples.tutorial.mainwnd.AbstractDesktopTask

Bug Category Details Line Priority
Exception thrown in class net.sf.jguiraffe.examples.tutorial.mainwnd.AbstractDesktopTask at new net.sf.jguiraffe.examples.tutorial.mainwnd.AbstractDesktopTask(MainWndController) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks. BAD_PRACTICE CT_CONSTRUCTOR_THROW 56 Medium
net.sf.jguiraffe.examples.tutorial.mainwnd.AbstractDesktopTask.getController() may expose internal representation by returning AbstractDesktopTask.controller MALICIOUS_CODE EI_EXPOSE_REP 79 Medium

net.sf.jguiraffe.examples.tutorial.mainwnd.DummyActionTask

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.mainwnd.DummyActionTask.setApplication(Application) may expose internal representation by storing an externally mutable object into DummyActionTask.application MALICIOUS_CODE EI_EXPOSE_REP2 49 Medium

net.sf.jguiraffe.examples.tutorial.mainwnd.FileSystemChangeListener

Bug Category Details Line Priority
new net.sf.jguiraffe.examples.tutorial.mainwnd.FileSystemChangeListener(MainWndController, ListComponentHandler) may expose internal representation by storing an externally mutable object into FileSystemChangeListener.controller MALICIOUS_CODE EI_EXPOSE_REP2 52 Medium

net.sf.jguiraffe.examples.tutorial.mainwnd.MainWndController

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.mainwnd.MainWndController.getApplication() may expose internal representation by returning MainWndController.application MALICIOUS_CODE EI_EXPOSE_REP 116 Medium
net.sf.jguiraffe.examples.tutorial.mainwnd.MainWndController.getTable() may expose internal representation by returning MainWndController.table MALICIOUS_CODE EI_EXPOSE_REP 136 Medium
net.sf.jguiraffe.examples.tutorial.mainwnd.MainWndController.getTree() may expose internal representation by returning MainWndController.tree MALICIOUS_CODE EI_EXPOSE_REP 126 Medium
net.sf.jguiraffe.examples.tutorial.mainwnd.MainWndController.getTreeModel() may expose internal representation by returning MainWndController.treeModel MALICIOUS_CODE EI_EXPOSE_REP 146 Medium
new net.sf.jguiraffe.examples.tutorial.mainwnd.MainWndController(Application, TreeHandler, TableHandler, WidgetHandler) may expose internal representation by storing an externally mutable object into MainWndController.application MALICIOUS_CODE EI_EXPOSE_REP2 100 Medium
new net.sf.jguiraffe.examples.tutorial.mainwnd.MainWndController(Application, TreeHandler, TableHandler, WidgetHandler) may expose internal representation by storing an externally mutable object into MainWndController.table MALICIOUS_CODE EI_EXPOSE_REP2 102 Medium
new net.sf.jguiraffe.examples.tutorial.mainwnd.MainWndController(Application, TreeHandler, TableHandler, WidgetHandler) may expose internal representation by storing an externally mutable object into MainWndController.tree MALICIOUS_CODE EI_EXPOSE_REP2 101 Medium
new net.sf.jguiraffe.examples.tutorial.mainwnd.MainWndController(Application, TreeHandler, TableHandler, WidgetHandler) may expose internal representation by storing an externally mutable object into MainWndController.widgetTable MALICIOUS_CODE EI_EXPOSE_REP2 103 Medium

net.sf.jguiraffe.examples.tutorial.mainwnd.RefreshActionTask

Bug Category Details Line Priority
new net.sf.jguiraffe.examples.tutorial.mainwnd.RefreshActionTask(MainWndController) may expose internal representation by storing an externally mutable object into RefreshActionTask.controller MALICIOUS_CODE EI_EXPOSE_REP2 43 Medium

net.sf.jguiraffe.examples.tutorial.mainwnd.SelectAndOpenFileTask

Bug Category Details Line Priority
new net.sf.jguiraffe.examples.tutorial.mainwnd.SelectAndOpenFileTask(FileChooserDialogService, MainWndController) may expose internal representation by storing an externally mutable object into SelectAndOpenFileTask.controller MALICIOUS_CODE EI_EXPOSE_REP2 84 Medium

net.sf.jguiraffe.examples.tutorial.mainwnd.TableChangeListener

Bug Category Details Line Priority
new net.sf.jguiraffe.examples.tutorial.mainwnd.TableChangeListener(MainWndController) may expose internal representation by storing an externally mutable object into TableChangeListener.controller MALICIOUS_CODE EI_EXPOSE_REP2 48 Medium

net.sf.jguiraffe.examples.tutorial.mainwnd.TreeChangeListener

Bug Category Details Line Priority
new net.sf.jguiraffe.examples.tutorial.mainwnd.TreeChangeListener(MainWndController) may expose internal representation by storing an externally mutable object into TreeChangeListener.controller MALICIOUS_CODE EI_EXPOSE_REP2 48 Medium

net.sf.jguiraffe.examples.tutorial.model.DirectoryData

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.model.DirectoryData.getContent() may expose internal representation by returning DirectoryData.content MALICIOUS_CODE EI_EXPOSE_REP 63 Medium
net.sf.jguiraffe.examples.tutorial.model.DirectoryData.setContent(List) may expose internal representation by storing an externally mutable object into DirectoryData.content MALICIOUS_CODE EI_EXPOSE_REP2 73 Medium

net.sf.jguiraffe.examples.tutorial.viewset.CreateViewSettingsCommand

Bug Category Details Line Priority
Exception thrown in class net.sf.jguiraffe.examples.tutorial.viewset.CreateViewSettingsCommand at new net.sf.jguiraffe.examples.tutorial.viewset.CreateViewSettingsCommand(ApplicationContext, ViewSettings, FormAction) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks. BAD_PRACTICE CT_CONSTRUCTOR_THROW 65 Medium
new net.sf.jguiraffe.examples.tutorial.viewset.CreateViewSettingsCommand(ApplicationContext, ViewSettings, FormAction) may expose internal representation by storing an externally mutable object into CreateViewSettingsCommand.appContext MALICIOUS_CODE EI_EXPOSE_REP2 63 Medium
new net.sf.jguiraffe.examples.tutorial.viewset.CreateViewSettingsCommand(ApplicationContext, ViewSettings, FormAction) may expose internal representation by storing an externally mutable object into CreateViewSettingsCommand.refreshAction MALICIOUS_CODE EI_EXPOSE_REP2 68 Medium
new net.sf.jguiraffe.examples.tutorial.viewset.CreateViewSettingsCommand(ApplicationContext, ViewSettings, FormAction) may expose internal representation by storing an externally mutable object into CreateViewSettingsCommand.viewSettings MALICIOUS_CODE EI_EXPOSE_REP2 67 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.getFileDateFrom() may expose internal representation by returning ViewSettings.fileDateFrom MALICIOUS_CODE EI_EXPOSE_REP 322 Medium
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.getFileDateTo() may expose internal representation by returning ViewSettings.fileDateTo MALICIOUS_CODE EI_EXPOSE_REP 332 Medium
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.getFileTypes() may expose internal representation by returning ViewSettings.fileTypes MALICIOUS_CODE EI_EXPOSE_REP 282 Medium
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.setFileDateFrom(Date) may expose internal representation by storing an externally mutable object into ViewSettings.fileDateFrom MALICIOUS_CODE EI_EXPOSE_REP2 327 Medium
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.setFileDateTo(Date) may expose internal representation by storing an externally mutable object into ViewSettings.fileDateTo MALICIOUS_CODE EI_EXPOSE_REP2 337 Medium
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.setFileTypes(String[]) may expose internal representation by storing an externally mutable object into ViewSettings.fileTypes MALICIOUS_CODE EI_EXPOSE_REP2 287 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDataComparator

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDataComparator.compare(FileData, FileData) negates the return value of java.util.Comparator.compare(Object, Object) BAD_PRACTICE RV_NEGATING_RESULT_OF_COMPARETO 531 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDateComparator

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDateComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 444-449 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDirComparator

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDirComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 457-490 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileNameComparator

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileNameComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 418-423 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileSizeComparator

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileSizeComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 431-436 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettingsFormController

Bug Category Details Line Priority
Exception thrown in class net.sf.jguiraffe.examples.tutorial.viewset.ViewSettingsFormController at new net.sf.jguiraffe.examples.tutorial.viewset.ViewSettingsFormController() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks. BAD_PRACTICE CT_CONSTRUCTOR_THROW 53 Medium